lkml.org 
[lkml]   [2018]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.15 26/72] RDMA/ucma: Check that device exists prior to accessing it
    Date
    4.15-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Leon Romanovsky <leonro@mellanox.com>

    commit c8d3bcbfc5eab3f01cf373d039af725f3b488813 upstream.

    Ensure that device exists prior to accessing its properties.

    Reported-by: <syzbot+71655d44855ac3e76366@syzkaller.appspotmail.com>
    Fixes: 75216638572f ("RDMA/cma: Export rdma cm interface to userspace")
    Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
    Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/infiniband/core/ucma.c | 6 ++++--
    1 file changed, 4 insertions(+), 2 deletions(-)

    --- a/drivers/infiniband/core/ucma.c
    +++ b/drivers/infiniband/core/ucma.c
    @@ -1335,7 +1335,7 @@ static ssize_t ucma_notify(struct ucma_f
    {
    struct rdma_ucm_notify cmd;
    struct ucma_context *ctx;
    - int ret;
    + int ret = -EINVAL;

    if (copy_from_user(&cmd, inbuf, sizeof(cmd)))
    return -EFAULT;
    @@ -1344,7 +1344,9 @@ static ssize_t ucma_notify(struct ucma_f
    if (IS_ERR(ctx))
    return PTR_ERR(ctx);

    - ret = rdma_notify(ctx->cm_id, (enum ib_event_type) cmd.event);
    + if (ctx->cm_id->device)
    + ret = rdma_notify(ctx->cm_id, (enum ib_event_type)cmd.event);
    +
    ucma_put_ctx(ctx);
    return ret;
    }

    \
     
     \ /
      Last update: 2018-04-06 16:04    [W:3.528 / U:0.128 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site