Messages in this thread |  | | Subject | Re: x86/dma conversion for v4.17-rc1 breaks sound / sst-acpi (commit 6e4bf5867783) | From | Pierre-Louis Bossart <> | Date | Fri, 6 Apr 2018 09:02:44 -0500 |
| |
On 04/05/2018 08:14 PM, Mark Brown wrote: > On Thu, Apr 05, 2018 at 10:56:57PM +0200, Dominik Brodowski wrote: >> Christoph, >> >> unfortunately, commit 6e4bf5867783 breaks sound on my Dell XPS13, see the >> dmesg diff between fec777c385b6 and 6e4bf5867783: > Adding Vinod and Pierre from Intel in case they have any ideas here. > Which model of XPS13 is this (2015?)? No clear idea, but this patch is odd. It claims to replace a dma_ops structure by an equivalent one but the callbacks for alloc/free are different.
-void *x86_swiotlb_alloc_coherent(struct device *hwdev, size_t size, - dma_addr_t *dma_handle, gfp_t flags, - unsigned long attrs) -{ - void *vaddr; - - /* - * Don't print a warning when the first allocation attempt fails. - * swiotlb_alloc_coherent() will print a warning when the DMA - * memory allocation ultimately failed. - */ - flags |= __GFP_NOWARN; - - vaddr = dma_direct_alloc(hwdev, size, dma_handle, flags, attrs); - if (vaddr) - return vaddr; - - return swiotlb_alloc_coherent(hwdev, size, dma_handle, flags); -} - -void x86_swiotlb_free_coherent(struct device *dev, size_t size, - void *vaddr, dma_addr_t dma_addr, - unsigned long attrs) -{ - if (is_swiotlb_buffer(dma_to_phys(dev, dma_addr))) - swiotlb_free_coherent(dev, size, vaddr, dma_addr); - else - dma_direct_free(dev, size, vaddr, dma_addr, attrs); -}
> >> -sst-acpi INT3438:00: DesignWare DMA Controller, 8 channels >> -haswell-pcm-audio haswell-pcm-audio: Direct firmware load for intel/IntcPP01.bin failed with error -2 >> -haswell-pcm-audio haswell-pcm-audio: fw image intel/IntcPP01.bin not available(-2) >> -haswell-pcm-audio haswell-pcm-audio: FW loaded, mailbox readback FW info: type 01, - version: 00.00, build 77, source commit id: 876ac6906f31a43b6772b23c7c983ce9dcb18a19 >> -broadwell-audio broadwell-audio: snd-soc-dummy-dai <-> System Pin mapping ok >> -broadwell-audio broadwell-audio: snd-soc-dummy-dai <-> Offload0 Pin mapping ok >> -broadwell-audio broadwell-audio: snd-soc-dummy-dai <-> Offload1 Pin mapping ok >> -broadwell-audio broadwell-audio: snd-soc-dummy-dai <-> Loopback Pin mapping ok >> -broadwell-audio broadwell-audio: rt286-aif1 <-> snd-soc-dummy-dai mapping ok >> -input: broadwell-rt286 Headset as /devices/pci0000:00/INT3438:00/broadwell-audio/sound/card1/input15 >> +broadwell-audio broadwell-audio: ASoC: CPU DAI System Pin not registered >> So it seems that sst-acpi is unhappy with this patch. Any ideas? >> Thanks, >> Dominik
|  |