lkml.org 
[lkml]   [2018]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 05/20] afs: Implement @sys substitution handling
On Thu, Apr 05, 2018 at 09:30:04PM +0100, David Howells wrote:
> +static struct dentry *afs_lookup_atsys(struct inode *dir, struct dentry *dentry,
> + struct key *key)
> +{

> + ret = lookup_one_len(buf, parent, len);

Er... Parent is locked only shared here and lookup_one_len() seriously depends
upon exclusive lock. As it is, race with lookup of the full name will mess the
things up very badly.

\
 
 \ /
  Last update: 2018-04-06 08:52    [W:0.193 / U:0.540 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site