lkml.org 
[lkml]   [2018]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 5/7] arm64: dts: renesas: eagle: Enable DU
    Date
    Hi Jacopo,

    Thank you for the patch.

    On Friday, 6 April 2018 16:08:10 EEST Jacopo Mondi wrote:
    > Enable DU for Renesas R-Car V3M Eagle board.
    >
    > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
    > ---
    > arch/arm64/boot/dts/renesas/r8a77970-eagle.dts | 11 +++++++++++
    > 1 file changed, 11 insertions(+)
    >
    > diff --git a/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts
    > b/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts index 3c5f598..144b847
    > 100644
    > --- a/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts
    > +++ b/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts
    > @@ -76,6 +76,11 @@
    > function = "i2c0";
    > };
    >
    > + du_pins: du {
    > + groups = "du_rgb666", "du_sync", "du_oddf", "du_clk_out";
    > + function = "du";
    > + };

    As far as I can tell the DU parallel output isn't used on the Eagle board, but
    is used on the Eagle expansion board. I would move this to patch 7/7 in this
    series.

    > scif0_pins: scif0 {
    > groups = "scif0_data";
    > function = "scif0";
    > @@ -93,3 +98,9 @@
    >
    > status = "okay";
    > };
    > +
    > +&du {
    > + pinctrl-0 = <&du_pins>;
    > + pinctrl-names = "default";

    These two properties should be moved to patch 7/7 too.

    > + status = "okay";
    > +};

    There's little use for enabling the DU in DT if you have no output port
    described. I'd move this to patch 6/7.

    --
    Regards,

    Laurent Pinchart



    \
     
     \ /
      Last update: 2018-04-06 15:48    [W:4.761 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site