[lkml]   [2018]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v4 6/9] vsprintf: Factor out %pV handler as va_format()
On Wed 2018-04-04 07:26:07, Joe Perches wrote:
> On Wed, 2018-04-04 at 10:58 +0200, Petr Mladek wrote:
> > Move the code from the long pointer() function. We are going to add a check
> > for the access to the address that will make it even more complicated.
> >
> > This patch does not change the existing behavior.
> But it might increase stack consumption.
> As the %pV is recursive, this is may not be a good thing.

It seems to be safe to pass just a pointer to struct printf_spec.
In fact, it would make sense to use this also in string() and
__string() calls. Copying 64 bytes many times look useless.

Do you think that other optimizations would be necessary?
For example, marking the function as inline?

Best Regards,

 \ /
  Last update: 2018-04-06 15:13    [W:0.071 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site