lkml.org 
[lkml]   [2018]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC PATCH 1/1 v2] vmscan: Support multiple kswapd threads per node
From
Date

> On Apr 4, 2018, at 11:10 PM, Michal Hocko <mhocko@kernel.org> wrote:
>
> On Wed 04-04-18 21:49:54, Buddy Lumpkin wrote:
>> v2:
>> - Make update_kswapd_threads_node less racy
>> - Handle locking for case where CONFIG_MEMORY_HOTPLUG=n
>
> Please do not repost with such a small changes. It is much more
> important to sort out the big picture first and only then deal with
> minor implementation details. The more versions you post the more
> fragmented and messy the discussion will become.
>
> You will have to be patient because this is a rather big change and it
> will take _quite_ some time to get sorted.
>
> Thanks!
> --
> Michal Hocko
> SUSE Labs
>


Sorry about that, I actually had three people review my code internally,
then I managed to send out an old version. 100% guilty of submitting
code when I needed sleep. As for the change, that was in response
to a request from Andrew to make the update function less racy.

Should I resend a correct v2 now that the thread exists?

—Buddy
\
 
 \ /
  Last update: 2018-04-06 08:26    [W:0.097 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site