Messages in this thread |  | | Date | Fri, 6 Apr 2018 13:43:33 +0200 | From | Petr Mladek <> | Subject | Re: [PATCH v4 4/9] vsprintf: Consolidate handling of unknown pointer specifiers |
| |
On Thu 2018-04-05 16:55:35, Joe Perches wrote: > On Thu, 2018-04-05 at 16:45 -0700, Joe Perches wrote: > > On Thu, 2018-04-05 at 16:25 +0200, Rasmus Villemoes wrote: > > > Even just git grep -1 -E '%p"$' finds %pt and %po > > > which should get fixed before somebody claims those extensions. > > > > Neither %pt nor %po is used in a vsprintf > > in the kernel. > > Nope, you are right, both are defectively used in the > kernel via string concatenation.
Ah, I see.
> Also there's a missing space in a concatenation adjacent.
> --- > arch/s390/kernel/perf_cpum_sf.c | 4 +--- > drivers/scsi/megaraid/megaraid_sas_base.c | 7 ++----- > 2 files changed, 3 insertions(+), 8 deletions(-) > > diff --git a/arch/s390/kernel/perf_cpum_sf.c b/arch/s390/kernel/perf_cpum_sf.c > index 1c9ddd7aa5ec..458b8f321043 100644 > --- a/arch/s390/kernel/perf_cpum_sf.c > +++ b/arch/s390/kernel/perf_cpum_sf.c > @@ -212,9 +212,7 @@ static int realloc_sampling_buffer(struct sf_buffer *sfb, > * the sampling buffer origin. > */ > if (sfb->sdbt != get_next_sdbt(tail)) { > - debug_sprintf_event(sfdbg, 3, "realloc_sampling_buffer: " > - "sampling buffer is not linked: origin=%p" > - "tail=%p\n", > + debug_sprintf_event(sfdbg, 3, "%s: sampling buffer is not linked: origin=%p tail=%p\n", ^^ I guess that you wanted to add __func__ as the next parameter?
Otherwise, the changes make perfect sense. Are you going to send them as proper patches, please?
Best Regards, Petr
|  |