lkml.org 
[lkml]   [2018]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3/4] perf, tools, record: Remove misleading error suggestion
    Date
    From: Andi Kleen <ak@linux.intel.com>

    When perf record encounters an error setting up an event it suggests
    to enable CONFIG_PERF_EVENTS. This is misleading because:
    - Usually it is enabled (it is really hard to disable on x86)
    - The problem is usually somewhere else, e.g. the CPU is not supported
    or an invalid configuration has been used.

    Remove the misleading suggestion.

    Signed-off-by: Andi Kleen <ak@linux.intel.com>
    ---
    tools/perf/util/evsel.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
    index 1ac8d9236efd..66b62570c855 100644
    --- a/tools/perf/util/evsel.c
    +++ b/tools/perf/util/evsel.c
    @@ -2894,8 +2894,7 @@ int perf_evsel__open_strerror(struct perf_evsel *evsel, struct target *target,

    return scnprintf(msg, size,
    "The sys_perf_event_open() syscall returned with %d (%s) for event (%s).\n"
    - "/bin/dmesg may provide additional information.\n"
    - "No CONFIG_PERF_EVENTS=y kernel support configured?",
    + "/bin/dmesg | grep -i perf may provide additional information.\n",
    err, str_error_r(err, sbuf, sizeof(sbuf)),
    perf_evsel__name(evsel));
    }
    --
    2.14.3
    \
     
     \ /
      Last update: 2018-04-06 22:38    [W:3.038 / U:0.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site