Messages in this thread Patch in this message |  | | Subject | Re: [PATCH v4 4/9] vsprintf: Consolidate handling of unknown pointer specifiers | From | Joe Perches <> | Date | Thu, 05 Apr 2018 16:55:35 -0700 |
| |
On Thu, 2018-04-05 at 16:45 -0700, Joe Perches wrote: > On Thu, 2018-04-05 at 16:25 +0200, Rasmus Villemoes wrote: > > Even just git grep -1 -E '%p"$' finds %pt and %po > > which should get fixed before somebody claims those extensions. > > Neither %pt nor %po is used in a vsprintf > in the kernel.
Nope, you are right, both are defectively used in the kernel via string concatenation.
Also there's a missing space in a concatenation adjacent.
--- arch/s390/kernel/perf_cpum_sf.c | 4 +--- drivers/scsi/megaraid/megaraid_sas_base.c | 7 ++----- 2 files changed, 3 insertions(+), 8 deletions(-)
diff --git a/arch/s390/kernel/perf_cpum_sf.c b/arch/s390/kernel/perf_cpum_sf.c index 1c9ddd7aa5ec..458b8f321043 100644 --- a/arch/s390/kernel/perf_cpum_sf.c +++ b/arch/s390/kernel/perf_cpum_sf.c @@ -212,9 +212,7 @@ static int realloc_sampling_buffer(struct sf_buffer *sfb, * the sampling buffer origin. */ if (sfb->sdbt != get_next_sdbt(tail)) { - debug_sprintf_event(sfdbg, 3, "realloc_sampling_buffer: " - "sampling buffer is not linked: origin=%p" - "tail=%p\n", + debug_sprintf_event(sfdbg, 3, "%s: sampling buffer is not linked: origin=%p tail=%p\n", (void *) sfb->sdbt, (void *) tail); return -EINVAL; } diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c index b89c6e6c0589..56f1c8132664 100644 --- a/drivers/scsi/megaraid/megaraid_sas_base.c +++ b/drivers/scsi/megaraid/megaraid_sas_base.c @@ -3546,14 +3546,11 @@ megasas_internal_reset_defer_cmds(struct megasas_instance *instance) for (i = 0; i < max_cmd; i++) { cmd = instance->cmd_list[i]; if (cmd->sync_cmd == 1 || cmd->scmd) { - dev_notice(&instance->pdev->dev, "moving cmd[%d]:%p:%d:%p" - "on the defer queue as internal\n", + dev_notice(&instance->pdev->dev, "moving cmd[%d]:%p:%d:%p on the defer queue as internal\n", defer_index, cmd, cmd->sync_cmd, cmd->scmd); if (!list_empty(&cmd->list)) { - dev_notice(&instance->pdev->dev, "ERROR while" - " moving this cmd:%p, %d %p, it was" - "discovered on some list?\n", + dev_notice(&instance->pdev->dev, "ERROR while moving this cmd:%p, %d %p, it was discovered on some list?\n", cmd, cmd->sync_cmd, cmd->scmd); list_del_init(&cmd->list);
|  |