Messages in this thread | | | From | Stephen Boyd <> | Subject | Re: [PATCH 2/2] dt-bindings: clock: Introduce QCOM RPMh clock bindings | Date | Thu, 05 Apr 2018 16:20:27 -0700 |
| |
Quoting Taniya Das (2018-03-28 23:17:53) > diff --git a/Documentation/devicetree/bindings/clock/qcom,rpmh.txt b/Documentation/devicetree/bindings/clock/qcom,rpmh.txt > new file mode 100644 > index 0000000..8222c88 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/qcom,rpmh.txt
Can the file name be qcom,rpmh-clk?
> @@ -0,0 +1,22 @@ > +Qualcomm Technologies, Inc. RPMh Clocks > +------------------------------------------------------- > + > +Resource Power Manager Hardened (RPMh) manages shared resources on > +some Qualcomm Technologies Inc. SoCs. It accepts clock requests from > +other hardware subsystems via RSC to control clocks. > + > +Required properties : > +- compatible : shall contain "qcom,rpmh-clk-sdm845" > + > +- #clock-cells : must contain 1 > + > +Example : > + > +#include <dt-bindings/clock/qcom,rpmh.h> > + > + &apps_rsc {
> + clock_rpmh: qcom,rpmhclk {
Should say clock-controller for node name.
> + compatible = "qcom,rpmh-clk-sdm845"; > + #clock-cells = <1>;
Is this tabbed out correctly?
> + }; > + };
| |