Messages in this thread |  | | From | Masahiro Yamada <> | Date | Fri, 6 Apr 2018 00:50:00 +0900 | Subject | Re: [PATCH 3/9] kbuild: Do not pass arguments to link-vmlinux.sh |
| |
2018-04-06 0:16 GMT+09:00 Jiri Olsa <jolsa@kernel.org>: > There's no need to pass LD* arguments to link-vmlinux.sh, > because they are passed as variables. The only argument > the link-vmlinux.sh supports is the 'clean' argument. > > Signed-off-by: Jiri Olsa <jolsa@kernel.org> > ---
Wrong.
$(LD) $(LDFLAGS) $(LDFLAGS_vmlinux) exist here so that any change in them invokes scripts/linkk-vmlinux.sh
> Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index d3300e46f925..a65a3919c6ad 100644 > --- a/Makefile > +++ b/Makefile > @@ -1027,7 +1027,7 @@ ARCH_POSTLINK := $(wildcard $(srctree)/arch/$(SRCARCH)/Makefile.postlink) > > # Final link of vmlinux with optional arch pass after final link > cmd_link-vmlinux = \ > - $(CONFIG_SHELL) $< $(LD) $(LDFLAGS) $(LDFLAGS_vmlinux) ; \ > + $(CONFIG_SHELL) $< ; \ > $(if $(ARCH_POSTLINK), $(MAKE) -f $(ARCH_POSTLINK) $@, true) > > vmlinux: scripts/link-vmlinux.sh vmlinux_prereq $(vmlinux-deps) FORCE
-- Best Regards Masahiro Yamada
|  |