Messages in this thread |  | | Date | Thu, 5 Apr 2018 09:21:05 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH] sched/rt: Fix rq->clock_update_flags < RQCF_ACT_SKIP warning |
| |
* Peter Zijlstra <peterz@infradead.org> wrote:
> On Wed, Apr 04, 2018 at 09:15:39AM -0700, Davidlohr Bueso wrote: > > On Mon, 02 Apr 2018, Davidlohr Bueso wrote: > > > > > The case for the rt task throttling (which this workload also hits) can be ignored in > > > that the skip_update call is actually bogus and quite the contrary (the request bits > > > are removed/reverted). > > > > While at it, how about this trivial patch? > > > > ----8<-------------------------------------------------------- > > [PATCH 2/1] sched: Simplify helpers for rq clock update skip requests > > > > By renaming the functions we can get rid of the skip parameter > > and have better code redability. It makes zero sense to have > > things such as: > > > > rq_clock_skip_update(rq, false) > > > > When the skip request is in fact not going to happen. Ever. Rename > > things such that we end up with: > > > > rq_clock_skip_update(rq) > > rq_clock_cancel_skipupdate(rq) > > > > Signed-off-by: Davidlohr Bueso <dbueso@suse.de> > > Works for me :-) > > Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
I have applied both patches, thanks guys!
Ingo
|  |