[lkml]   [2018]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [RFC 1/3] drm: Add DAMAGE_CLIPS property to plane
On 04/05/2018 12:03 PM, Daniel Vetter wrote:
> On the topic of input validation: Should the kernel check in shared code
> that all the clip rects are sensible, i.e. within the dimensions of the
> fb? Relying on drivers for that seems like a bad idea.

I guess we could do that.

There seems to be different needs for different kinds of iterators, but
I was thinking that an iterator could just skip invalid rects if found.
Then we
don't need a separate validation step, but OTOH user-space won't get
notified if
that was intended.

I'm not 100% sure user-space would do anything sensible with any error
information, though.


> That could be done in core code in drm_atomic_plane_check().
> -Daniel
>> /Thomas
>> _______________________________________________
>> dri-devel mailing list

 \ /
  Last update: 2018-04-05 13:42    [W:0.084 / U:2.336 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site