[lkml]   [2018]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] prctl: Deprecate non PR_SET_MM_MAP operations
On 04/04/2018 01:04 PM, Cyrill Gorcunov wrote:
> On Wed, Apr 04, 2018 at 12:24:33PM -0700, Randy Dunlap wrote:
>>> + pr_warn_once("Non PR_SET_MM_MAP operations are deprecated\n");
>>> + return -EINVAL;
>>> }
>> I'm not against removing such functionality, but I think that it's more than
>> "deprecated." It's gone.
> At first this was plain warning without code removal but I've
> been advised that dropping it completely may be a better idea
> which I agree Or you mean the
> warning message itsef? We aready have similars, for example
> in kernel/auditfilter.c

The traditional way (eons ago) to deprecate something was to add a
printk() and then delete the feature a few years later.
Still, I have no objection to dropping that prctl.

Sorry if I wasn't clear. I was objecting to the "language", i.e., to the
word "deprecated." Deprecated means frowned on, advised against, etc.
It does not mean "deleted."

> printk(KERN_ERR "AUDIT_POSSIBLE is deprecated\n");

Yeah, that one's wrong also. :)


 \ /
  Last update: 2018-04-04 22:54    [W:0.052 / U:0.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site