Messages in this thread |  | | Subject | Re: [PATCH] prctl: Deprecate non PR_SET_MM_MAP operations | From | Randy Dunlap <> | Date | Wed, 4 Apr 2018 13:53:08 -0700 |
| |
On 04/04/2018 01:04 PM, Cyrill Gorcunov wrote: > On Wed, Apr 04, 2018 at 12:24:33PM -0700, Randy Dunlap wrote: >> >>> + pr_warn_once("Non PR_SET_MM_MAP operations are deprecated\n"); >>> + return -EINVAL; >>> } >> >> I'm not against removing such functionality, but I think that it's more than >> "deprecated." It's gone. > > At first this was plain warning without code removal but I've > been advised that dropping it completely may be a better idea > which I agree https://lkml.org/lkml/2018/4/4/31 Or you mean the > warning message itsef? We aready have similars, for example > in kernel/auditfilter.c
The traditional way (eons ago) to deprecate something was to add a printk() and then delete the feature a few years later. Still, I have no objection to dropping that prctl.
Sorry if I wasn't clear. I was objecting to the "language", i.e., to the word "deprecated." Deprecated means frowned on, advised against, etc. It does not mean "deleted."
> printk(KERN_ERR "AUDIT_POSSIBLE is deprecated\n");
Yeah, that one's wrong also. :)
-- ~Randy
|  |