Messages in this thread | | | Date | Wed, 4 Apr 2018 15:30:39 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH v2] tracing, printk: Force no hashing when trace_printk() is used |
| |
On Wed, 4 Apr 2018 12:04:42 -0700 Linus Torvalds <torvalds@linux-foundation.org> wrote:
> > So at the *very* least this would need to be percpu logic, but even > that is honestly broken since an NMI might come in and want to printk > too. > > Why don't you just use %px? That avoids all of these hacks.
Just need to remember to do that. I guess with time it will become second nature.
> > So NAK on this stupid "enable and disable hashing that is > fundamentally broken" approach. >
OK. I'll save the change locally, and add it while debugging kernels. ktest can do that for me ;-)
-- Steve
| |