Messages in this thread | | | Date | Wed, 04 Apr 2018 11:41:56 -0400 (EDT) | Subject | Re: [PATCH v2] lan78xx: Connect phy early | From | David Miller <> |
| |
From: Alexander Graf <agraf@suse.de> Date: Wed, 4 Apr 2018 00:19:35 +0200
> When using wicked with a lan78xx device attached to the system, we > end up with ethtool commands issued on the device before an ifup > got issued. That lead to the following crash: > ... > The culprit is quite simple: The driver tries to access the phy left and right, > but only actually has a working reference to it when the device is up. > > The fix thus is quite simple too: Get a reference to the phy on probe already > and keep it even when the device is going down. > > With this patch applied, I can successfully run wicked on my system and bring > the interface up and down as many times as I want, without getting NULL pointer > dereferences in between. > > Signed-off-by: Alexander Graf <agraf@suse.de>
Applied, thank you.
| |