lkml.org 
[lkml]   [2018]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [kvmtool PATCH 21/17] kvmtool: arm: Add support for creating VM with PA size
    From
    Date
    On 30/04/18 15:17, Julien Grall wrote:
    > Hi,
    >
    > On 27/03/18 14:15, Suzuki K Poulose wrote:
    >> diff --git a/arm/kvm.c b/arm/kvm.c
    >> index 5701d41..a9a9140 100644
    >> --- a/arm/kvm.c
    >> +++ b/arm/kvm.c
    >> @@ -11,6 +11,8 @@
    >>   #include <linux/kvm.h>
    >>   #include <linux/sizes.h>
    >> +unsigned long kvm_arm_type;
    >> +
    >>   struct kvm_ext kvm_req_ext[] = {
    >>       { DEFINE_KVM_EXT(KVM_CAP_IRQCHIP) },
    >>       { DEFINE_KVM_EXT(KVM_CAP_ONE_REG) },
    >> @@ -18,6 +20,25 @@ struct kvm_ext kvm_req_ext[] = {
    >>       { 0, 0 },
    >>   };
    >> +#ifndef KVM_ARM_GET_MAX_VM_PHYS_SHIFT
    >> +#define KVM_ARM_GET_MAX_VM_PHYS_SHIFT        _IO(KVMIO, 0x0a)
    >> +#endif
    >> +
    >> +void kvm__arch_init_hyp(struct kvm *kvm)
    >> +{
    >> +    unsigned max_ipa;
    >> +
    >> +    max_ipa = ioctl(kvm->sys_fd, KVM_ARM_GET_MAX_VM_PHYS_SHIFT);
    >> +    if (max_ipa < 0)
    >
    > Another issues spotted while doing some testing. This will always be false because max_ipa is unsigned.
    >
    > I think we want to turn max_ipa to signed.

    Good catch. I will fix it.

    Cheers
    Suzuki

    \
     
     \ /
      Last update: 2018-04-30 16:19    [W:2.667 / U:1.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site