lkml.org 
[lkml]   [2018]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3/4] usb: typec: fusb302: Fix debugfs issue
    Date
    Removing the "fusb302" debugfs directory when unloading
    the driver. That allows the driver to be loaded more then
    ones.

    This fixes an issue where the driver, if unloaded, can't be
    re-loaded, as the "fusb302" debugfs directory already
    exists. While here, removing useless condition when creating
    the debugfs directory.

    Fixes: 76f0c53d08b9 ("usb: typec: fusb302: Move out of staging")
    Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
    ---
    drivers/usb/typec/fusb302/fusb302.c | 9 ++++-----
    1 file changed, 4 insertions(+), 5 deletions(-)

    diff --git a/drivers/usb/typec/fusb302/fusb302.c b/drivers/usb/typec/fusb302/fusb302.c
    index eba6bb890b17..0e5d0aa052f5 100644
    --- a/drivers/usb/typec/fusb302/fusb302.c
    +++ b/drivers/usb/typec/fusb302/fusb302.c
    @@ -218,11 +218,9 @@ static struct dentry *rootdir;
    static int fusb302_debugfs_init(struct fusb302_chip *chip)
    {
    mutex_init(&chip->logbuffer_lock);
    - if (!rootdir) {
    - rootdir = debugfs_create_dir("fusb302", NULL);
    - if (!rootdir)
    - return -ENOMEM;
    - }
    + rootdir = debugfs_create_dir("fusb302", NULL);
    + if (!rootdir)
    + return -ENOMEM;

    chip->dentry = debugfs_create_file(dev_name(chip->dev),
    S_IFREG | 0444, rootdir,
    @@ -234,6 +232,7 @@ static int fusb302_debugfs_init(struct fusb302_chip *chip)
    static void fusb302_debugfs_exit(struct fusb302_chip *chip)
    {
    debugfs_remove(chip->dentry);
    + debugfs_remove(rootdir);
    }

    #else
    --
    2.17.0
    \
     
     \ /
      Last update: 2018-04-30 14:42    [W:2.441 / U:0.376 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site