lkml.org 
[lkml]   [2018]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 2/6] backlight/generic-bl: remove DRIVER1 state
    Date
    On Wed, 25 Apr 2018, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
    > Nothing in the entire tree ever sets this, which means this is dead
    > code. Remove it.
    >
    > Cc: Lee Jones <lee.jones@linaro.org>
    > Cc: Daniel Thompson <daniel.thompson@linaro.org>
    > Cc: Jingoo Han <jingoohan1@gmail.com>
    > Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
    > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>

    Reviewed-by: Jani Nikula <jani.nikula@intel.com>

    > ---
    > drivers/video/backlight/generic_bl.c | 5 -----
    > 1 file changed, 5 deletions(-)
    >
    > diff --git a/drivers/video/backlight/generic_bl.c b/drivers/video/backlight/generic_bl.c
    > index 67dfb939a514..4dea91acea13 100644
    > --- a/drivers/video/backlight/generic_bl.c
    > +++ b/drivers/video/backlight/generic_bl.c
    > @@ -21,9 +21,6 @@ static int genericbl_intensity;
    > static struct backlight_device *generic_backlight_device;
    > static struct generic_bl_info *bl_machinfo;
    >
    > -/* Flag to signal when the battery is low */
    > -#define GENERICBL_BATTLOW BL_CORE_DRIVER1
    > -
    > static int genericbl_send_intensity(struct backlight_device *bd)
    > {
    > int intensity = bd->props.brightness;
    > @@ -34,8 +31,6 @@ static int genericbl_send_intensity(struct backlight_device *bd)
    > intensity = 0;
    > if (bd->props.state & BL_CORE_SUSPENDED)
    > intensity = 0;
    > - if (bd->props.state & GENERICBL_BATTLOW)
    > - intensity &= bl_machinfo->limit_mask;
    >
    > bl_machinfo->set_bl_intensity(intensity);

    --
    Jani Nikula, Intel Open Source Technology Center

    \
     
     \ /
      Last update: 2018-04-30 12:18    [W:4.542 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site