Messages in this thread | | | From | Kees Cook <> | Date | Mon, 30 Apr 2018 15:40:29 -0700 | Subject | Re: [PATCH v6 3/8] sysctl: Warn when a clamped sysctl parameter is set out of range |
| |
I like this series overall, thanks! No objections from me. One thing I noted, though:
On Fri, Apr 27, 2018 at 2:00 PM, Waiman Long <longman@redhat.com> wrote: > if (param->min && *param->min > val) { > if (clamp) { > val = *param->min; > + clamped = true; > } else { > return -EINVAL; > }
This appears as a common bit of logic in many places in the series. It seems like it'd make sense to make this a helper of some kind?
-Kees
-- Kees Cook Pixel Security
| |