Messages in this thread | | | Date | Wed, 4 Apr 2018 11:34:55 +0900 | From | Sergey Senozhatsky <> | Subject | Re: [PATCH v2] tracing, printk: Force no hashing when trace_printk() is used |
| |
On (04/03/18 18:03), Steven Rostedt wrote: > > > he'd want you to change all the trace_printk()s to %px with > > justifications, though. > > What trace_printk()s do you want to change? They are throw away > functions. trace_printk() is not something that stays in the kernel. > It's added during debugging and then removed before submitting what you > are working on upstream.
Seems that your patch also can fix up bpf_trace_printk() - it doesn't even support %px, only hashed %p, which it passes to __trace_printk().
-ss
| |