lkml.org 
[lkml]   [2018]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 5/7] kprobes/x86: Fix %p uses in error messages
On Fri, 27 Apr 2018 08:58:17 +0200
Ingo Molnar <mingo@kernel.org> wrote:

>
> * Masami Hiramatsu <mhiramat@kernel.org> wrote:
>
> > (addr < (u8 *) jprobe_return_end)) {
> > if (stack_addr(regs) != saved_sp) {
> > struct pt_regs *saved_regs = &kcb->jprobe_saved_regs;
> > - printk(KERN_ERR
> > - "current sp %p does not match saved sp %p\n",
> > + pr_err("current sp %pS does not match saved sp %pS\n",
> > stack_addr(regs), saved_sp);
>
> Why does this use %pS? Stack pointers are typically pointing into general kernel
> RAM, which is totally pointless to display 'symbolically'.

That was I pointed in the last thread, but not accepted.
OK, anyway, there are no good reason to show such a dynamic value.
And now jprobes are gone. I just drop %p from this part.

Thanks,


--
Masami Hiramatsu <mhiramat@kernel.org>

\
 
 \ /
  Last update: 2018-04-27 17:07    [W:0.041 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site