Messages in this thread | | | Date | Fri, 27 Apr 2018 13:58:33 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH v2] x86/PCI: Make pci=earlydump output neat |
| |
* Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> Currently the early dump of PCI configuration space looks quite unhelpful, e.g. > > [ 0.000000] 60: > [ 0.000000] 00 > [ 0.000000] 00 > [ 0.000000] 00 > [ 0.000000] 00 > [ 0.000000] 00 > [ 0.000000] 00 > [ 0.000000] 00 > [ 0.000000] 00 > [ 0.000000] 00 > [ 0.000000] 00 > [ 0.000000] 00 > [ 0.000000] 00 > [ 0.000000] 00 > [ 0.000000] 00 > [ 0.000000] 00 > [ 0.000000] 00 > [ 0.000000] > > which makes really hard to get anything out of this. Convert the function to > use print_hex_dump() to make output neat. > > In the result we will have > > [ 0.000000] 00000060: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > > which is much, much better. > > Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Ingo Molnar <mingo@kernel.org>
Thanks,
Ingo
| |