Messages in this thread | | | Date | Thu, 26 Apr 2018 14:21:36 -0600 | From | Johannes Thumshirn <> | Subject | Re: [PATCH] nvme: change order of qid and cmdid in completion trace |
| |
On Thu, Apr 26, 2018 at 02:01:59PM -0600, Jens Axboe wrote: > On 4/26/18 1:49 PM, Johannes Thumshirn wrote: > > Keith reported that command submission and command completion > > tracepoints have the order of the cmdid and qid fileds swapped. > > > > While it isn't easily possible to change the command submission > > tracepoint, as there is a regression test parsing it in blktests we > > can swap the command completion tracepoint to have the fileds aligned. > > It also makes more sense to have qid before cmdid. > > Also, fileds -> fields, in two spots.
Args. Thanks
-- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
| |