Messages in this thread | | | Date | Thu, 26 Apr 2018 22:24:44 +0300 | From | Alexey Dobriyan <> | Subject | Re: [PATCH] proc: use #pragma once |
| |
On Thu, Apr 26, 2018 at 12:26:29PM +0200, David Sterba wrote: > On Wed, Apr 25, 2018 at 11:55:31PM +0300, Alexey Dobriyan wrote: > > On Tue, Apr 24, 2018 at 06:54:09AM -0700, Christoph Hellwig wrote: > > > On Tue, Apr 24, 2018 at 12:35:34AM +0300, Alexey Dobriyan wrote: > > > > Bring /proc into 21st century. > > > > > > Please explain what this actually buys us except for being pointlessly > > > different from the rest of the kernel? > > > > Negative LOC diff, less junk in preprocessor hashtables. > > There are about 20k header files, none of them has #pragma once. > Updating that will bring many unnesessry git commits.
If you don't obey sometimes silly rule re splitting patches, it can be done in much less.
> I doubt that one more define in preprocessor tables is a problem we > should fix.
Those eat cycles and memory one define at a time.
> The LOC argument also does not sound very convincing.
When was the last time you did -80 kLOC patch for free?
> The include protection is at the top of the file, not mixed among other > code. Replacing 2-3 lines with one will be barely noticeable.
| |