Messages in this thread | | | From | Miklos Szeredi <> | Date | Thu, 26 Apr 2018 15:25:53 +0200 | Subject | Re: [PATCH v5 2/2] tracing: remove igrab() iput() call from uprobes.c |
| |
On Mon, Apr 23, 2018 at 7:21 PM, Song Liu <songliubraving@fb.com> wrote: > Caller of uprobe_register is required to keep the inode and containing > mount point referenced. > > There was misuse of igrab() in uprobes.c and trace_uprobe.c. This is > because igrab() will not prevent umount of the containing mount point. > To fix this, we added path to struct trace_uprobe, which keeps the inode > and containing mount reference. > > For uprobes.c, it is not necessary to call igrab() in uprobe_register(), > as the caller is required to keep the inode reference. The igrab() is > removed and comments on this requirement is added to uprobe_register(). > > Link: http://lkml.kernel.org/r/CAELBmZB2XX=qEOLAdvGG4cPx4GEntcSnWQquJLUK1ongRj35cA@mail.gmail.com > Cc: Steven Rostedt <rostedt@goodmis.org> > Cc: Ingo Molnar <mingo@redhat.com> > Cc: Howard McLauchlan <hmclauchlan@fb.com> > Cc: Josef Bacik <jbacik@fb.com> > Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com> > Cc: Miklos Szeredi <miklos@szeredi.hu> > Signed-off-by: Song Liu <songliubraving@fb.com>
Acked-by: Miklos Szeredi <mszeredi@redhat.com>
| |