Messages in this thread | | | Subject | Re: [PATCH] net: dwc-xlgmac: fix xlgmac_xmit()'s return type | From | Jose Abreu <> | Date | Thu, 26 Apr 2018 11:42:55 +0100 |
| |
On 24-04-2018 14:17, Luc Van Oostenryck wrote: > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, but the implementation in this > driver returns an 'int'. > > Fix this by returning 'netdev_tx_t' in this driver too. > > Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com> > ---
I wouldn't do this because of at least two reasons: - xlgmac_xmit() calls xlgmac_maybe_stop_tx_queue() and xlgmac_prep_tso(), and this last one can return a negative error code. I expect some others drivers to have similar behavior. - If you look along net subsystem you will see that this enum is directly converted to an int in later stages.
So, and given that you sent a large number of patches about this, perhaps it would be more clear to change the function definition?
Thanks and Best Regards, Jose Miguel Abreu
| |