Messages in this thread | | | From | Linus Walleij <> | Date | Thu, 26 Apr 2018 10:10:11 +0200 | Subject | Re: [PATCH 1/2] gpio: eic: Add edge trigger emulation for EIC |
| |
On Fri, Mar 30, 2018 at 9:02 AM, Baolin Wang <baolin.wang@linaro.org> wrote:
> The Spreadtrum debounce EIC and latch EIC can not support edge trigger, > but most GPIO users (like gpio-key driver) only use the edge trigger, > thus the EIC driver need add some support to emulate the edge trigger > to satisfy this requirement. > > Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
Patch applied.
The patch is fine and in line with other kernel drivers doing edge trigger emulation and we do not hold back on useful features.
But I want to take this opportunity to ping Uwe Kleine-König about his ideas for an edge trigger emulation library in the gpiolib core, and whether this also follows the pattern.
I think we have a slew of these drivers doing similar stuff around.
Yours, Linus Walleij
| |