Messages in this thread | | | Date | Fri, 27 Apr 2018 11:39:51 +0900 | From | Masami Hiramatsu <> | Subject | Re: [PATCH -tip v2 4/7] kprobes: Replace %p with other pointer types |
| |
On Thu, 26 Apr 2018 21:13:51 -0400 Steven Rostedt <rostedt@goodmis.org> wrote:
> On Thu, 26 Apr 2018 17:10:03 +0900 > Masami Hiramatsu <mhiramat@kernel.org> wrote: > > > Replace %p with appropriate pointer types (or just remove it) > > - Use %pS if possible > > - Use %px only for the function right before BUG(). > > - Remove unneeded error message. > > I'm not sure "right before BUG()" is legitimate for using %px. Why not > still use %pS?
Since BUG() will dump all registers and stacks which includes raw address information and reboot the system (means reset the kaslr base offset), I thought it may not add additional damage.
Anyway, for this patch we can use %pS. For the next [5/7] patch, I'm not sure %pS is good for dumping a stack address...
Thank you,
> > -- Steve >
-- Masami Hiramatsu <mhiramat@kernel.org>
| |