Messages in this thread | | | Date | Thu, 26 Apr 2018 09:39:47 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH 3/3] tools bpftool: Display license GPL compatible in prog show/list |
| |
On Wed, Apr 25, 2018 at 02:03:46PM -0700, Jakub Kicinski wrote: > On Wed, 25 Apr 2018 19:41:08 +0200, Jiri Olsa wrote: > > @@ -295,6 +297,7 @@ static void print_prog_plain(struct bpf_prog_info *info, int fd) > > printf("tag "); > > fprint_hex(stdout, info->tag, BPF_TAG_SIZE, ""); > > print_dev_plain(info->ifindex, info->netns_dev, info->netns_ino); > > + printf(" license GPL %scompatible", info->gpl_compatible ? "" : "NON "); > > 3 nit picks: > > Other "fields" are separated by two spaces between each other: > > 4: kprobe name func_begin tag 57cd311f2e27366b license GPL compatible > ^^ ^^ X > loaded_at Apr 25/11:20 uid 0 > ^^ > xlated 16B not jited memlock 4096B > ^^ ^^ >
will change
> Could you also update the example outputs in the man page: > > tools/bpf/bpftool/Documentation/bpftool-prog.rst
oops, I always forget that.. will do
thanks, jirka
| |