lkml.org 
[lkml]   [2018]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 6/6] rpmsg: glink: Expose rpmsg name attr for glink
    Hi Chris,

    Thank you for the patch! Perhaps something to improve:

    [auto build test WARNING on robh/for-next]
    [also build test WARNING on v4.17-rc2 next-20180426]
    [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

    url: https://github.com/0day-ci/linux/commits/Chris-Lew/Add-chrdev-and-name-query-support-for-GLINK/20180427-023202
    base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
    config: i386-randconfig-b0-04270034 (attached as .config)
    compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
    reproduce:
    # save the attached .config to linux build tree
    make ARCH=i386

    All warnings (new ones prefixed by >>):

    In file included from include/linux/kobject.h:20:0,
    from include/linux/irqdesc.h:6,
    from include/linux/irq.h:517,
    from arch/x86/include/asm/hardirq.h:6,
    from include/linux/hardirq.h:9,
    from include/linux/interrupt.h:11,
    from drivers/rpmsg/qcom_glink_native.c:15:
    >> include/linux/sysfs.h:153:21: warning: initialization from incompatible pointer type
    static const struct attribute_group _name##_group = { \
    ^
    >> drivers/rpmsg/qcom_glink_native.c:1569:1: note: in expansion of macro 'ATTRIBUTE_GROUPS'
    ATTRIBUTE_GROUPS(qcom_glink);
    ^
    include/linux/sysfs.h:153:21: warning: (near initialization for 'qcom_glink_group.attrs')
    static const struct attribute_group _name##_group = { \
    ^
    >> drivers/rpmsg/qcom_glink_native.c:1569:1: note: in expansion of macro 'ATTRIBUTE_GROUPS'
    ATTRIBUTE_GROUPS(qcom_glink);
    ^
    --
    In file included from include/linux/kobject.h:20:0,
    from include/linux/irqdesc.h:6,
    from include/linux/irq.h:517,
    from arch/x86/include/asm/hardirq.h:6,
    from include/linux/hardirq.h:9,
    from include/linux/interrupt.h:11,
    from drivers//rpmsg/qcom_glink_native.c:15:
    >> include/linux/sysfs.h:153:21: warning: initialization from incompatible pointer type
    static const struct attribute_group _name##_group = { \
    ^
    drivers//rpmsg/qcom_glink_native.c:1569:1: note: in expansion of macro 'ATTRIBUTE_GROUPS'
    ATTRIBUTE_GROUPS(qcom_glink);
    ^
    include/linux/sysfs.h:153:21: warning: (near initialization for 'qcom_glink_group.attrs')
    static const struct attribute_group _name##_group = { \
    ^
    drivers//rpmsg/qcom_glink_native.c:1569:1: note: in expansion of macro 'ATTRIBUTE_GROUPS'
    ATTRIBUTE_GROUPS(qcom_glink);
    ^

    vim +/ATTRIBUTE_GROUPS +1569 drivers/rpmsg/qcom_glink_native.c

    1564
    1565 static const struct attribute *qcom_glink_attrs[] = {
    1566 &dev_attr_rpmsg_name.attr,
    1567 NULL
    1568 };
    > 1569 ATTRIBUTE_GROUPS(qcom_glink);
    1570

    ---
    0-DAY kernel test infrastructure Open Source Technology Center
    https://lists.01.org/pipermail/kbuild-all Intel Corporation
    [unhandled content-type:application/gzip]
    \
     
     \ /
      Last update: 2018-04-27 02:12    [W:2.396 / U:0.500 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site