Messages in this thread | | | Subject | Re: [PATCH v5 02/11] vsprintf: Add missing const ptr qualifier to prt_to_id() | From | Andy Shevchenko <> | Date | Wed, 25 Apr 2018 17:57:28 +0300 |
| |
On Wed, 2018-04-25 at 13:12 +0200, Petr Mladek wrote: > vsprintf() must not change any data that parameters point to. > Let's add the missing const qualifier to ptr_to_id(). > > This patch does not change the existing behavior. >
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Petr Mladek <pmladek@suse.com> > --- > lib/vsprintf.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lib/vsprintf.c b/lib/vsprintf.c > index 19fdfe621b40..eef9f725e9ff 100644 > --- a/lib/vsprintf.c > +++ b/lib/vsprintf.c > @@ -661,7 +661,8 @@ static int __init initialize_ptr_random(void) > early_initcall(initialize_ptr_random); > > /* Maps a pointer to a 32 bit unique identifier. */ > -static char *ptr_to_id(char *buf, char *end, void *ptr, struct > printf_spec spec) > +static char *ptr_to_id(char *buf, char *end, const void *ptr, > + struct printf_spec spec) > { > const char *str = sizeof(ptr) == 8 ? "(____ptrval____)" : > "(ptrval)"; > unsigned long hashval;
-- Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy
| |