Messages in this thread Patch in this message | | | From | Michal Simek <> | Subject | [PATCH] earlycon: Remove hardcoded port->uartclk initialization in of_setup_earlycon | Date | Wed, 25 Apr 2018 15:48:42 +0200 |
| |
There is no reason to initialize uartclk to BASE_BAUD * 16 for DT based systems.
Signed-off-by: Michal Simek <michal.simek@xilinx.com> Tested-by: Matt Redfearn <matt.redfearn@mips.com> ---
It looks like from history that portclk = BASE_BAUD * 16 was setup to get on calculation on x86 (divisor = 1) but it shouldn't be needed on DT based system. That's why I think that there is no DT based system which really requires this line. --- drivers/tty/serial/earlycon.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/tty/serial/earlycon.c b/drivers/tty/serial/earlycon.c index a24278380fec..c12b1edcdd8e 100644 --- a/drivers/tty/serial/earlycon.c +++ b/drivers/tty/serial/earlycon.c @@ -244,7 +244,6 @@ int __init of_setup_earlycon(const struct earlycon_id *match, return -ENXIO; } port->mapbase = addr; - port->uartclk = BASE_BAUD * 16; val = of_get_flat_dt_prop(node, "reg-offset", NULL); if (val) -- 2.17.0
| |