Messages in this thread | | | Subject | Re: [PATCH v5 06/11] vsprintf: Factor out %p[iI] handler as ip_addr_string() | From | Andy Shevchenko <> | Date | Wed, 25 Apr 2018 16:11:08 +0300 |
| |
On Wed, 2018-04-25 at 13:12 +0200, Petr Mladek wrote: > Move the non-trivial code from the long pointer() function. We are > going > to add a check for the access to the address that will make it even > more > complicated. > > Also it is better to warn about unknown specifier instead of falling > back to the %p behavior. It will help people to understand what is > going wrong. They expect the IP address and not a pointer anyway > in this situation. >
Can we split to 1) move out + 2) misc changes ?
> + return valid_string(buf, end, "(invalid > address)", > + spec);
I would still put it on one line.
-- Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy
| |