lkml.org 
[lkml]   [2018]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 037/183] scsi: qla2xxx: Fix warning in qla2x00_async_iocb_timeout()
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: "himanshu.madhani@cavium.com" <himanshu.madhani@cavium.com>


    [ Upstream commit 7ac0c332f96bb9688560726f5e80c097ed8de59a ]

    This patch fixes following Smatch warning:

    drivers/scsi/qla2xxx/qla_init.c:130 qla2x00_async_iocb_timeout() error: we previously assumed 'fcport' could be null (see line 107)

    Fixes: 5c25d451163c ("scsi: qla2xxx: Fix NULL pointer access for fcport structure")
    Reported by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Quinn Tran <quinn.tran@cavium.com>
    Signed-off-by: Himanshu Madhani <himanshu.madhani@cavium.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/scsi/qla2xxx/qla_init.c | 4 ++++
    1 file changed, 4 insertions(+)

    --- a/drivers/scsi/qla2xxx/qla_init.c
    +++ b/drivers/scsi/qla2xxx/qla_init.c
    @@ -115,6 +115,8 @@ qla2x00_async_iocb_timeout(void *data)

    switch (sp->type) {
    case SRB_LOGIN_CMD:
    + if (!fcport)
    + break;
    /* Retry as needed. */
    lio->u.logio.data[0] = MBS_COMMAND_ERROR;
    lio->u.logio.data[1] = lio->u.logio.flags & SRB_LOGIN_RETRIED ?
    @@ -128,6 +130,8 @@ qla2x00_async_iocb_timeout(void *data)
    qla24xx_handle_plogi_done_event(fcport->vha, &ea);
    break;
    case SRB_LOGOUT_CMD:
    + if (!fcport)
    + break;
    qlt_logo_completion_handler(fcport, QLA_FUNCTION_TIMEOUT);
    break;
    case SRB_CT_PTHRU_CMD:

    \
     
     \ /
      Last update: 2018-04-25 13:29    [W:4.036 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site