lkml.org 
[lkml]   [2018]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 009/183] drm/i915: Do no use kfree() to free a kmem_cache_alloc() return value
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Xidong Wang <wangxidong_97@163.com>

    commit fcf1fadf4c65eea6c519c773d2d9901e8ad94f5f upstream.

    Along the eb_lookup_vmas() error path, the return value from
    kmem_cache_alloc() was freed using kfree(). Fix it to use the proper
    kmem_cache_free() instead.

    Fixes: d1b48c1e7184 ("drm/i915: Replace execbuf vma ht with an idr")
    Signed-off-by: Xidong Wang <wangxidong_97@163.com>
    Cc: Chris Wilson <chris@chris-wilson.co.uk>
    Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
    Cc: <stable@vger.kernel.org> # v4.14+
    Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
    Link: https://patchwork.freedesktop.org/patch/msgid/20180404093824.9313-1-chris@chris-wilson.co.uk
    (cherry picked from commit 6be1187dbffa0027ea379c53f7ca0c782515c610)
    Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/gpu/drm/i915/i915_gem_execbuffer.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/gpu/drm/i915/i915_gem_execbuffer.c
    +++ b/drivers/gpu/drm/i915/i915_gem_execbuffer.c
    @@ -722,7 +722,7 @@ static int eb_lookup_vmas(struct i915_ex

    err = radix_tree_insert(handles_vma, handle, vma);
    if (unlikely(err)) {
    - kfree(lut);
    + kmem_cache_free(eb->i915->luts, lut);
    goto err_obj;
    }


    \
     
     \ /
      Last update: 2018-04-25 12:39    [W:4.039 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site