lkml.org 
[lkml]   [2018]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH 0/3] bpf: Store/dump license string for loaded program
    On Mon, Apr 23, 2018 at 02:11:36PM -0600, Alexei Starovoitov wrote:
    > On Mon, Apr 23, 2018 at 08:59:24AM +0200, Jiri Olsa wrote:
    > > hi,
    > > sending the change to store and dump the license
    > > info for loaded BPF programs. It's important for
    > > us get the license info, when investigating on
    > > screwed up machine.
    >
    > hmm. boolean flag whether bpf prog is gpl or not
    > is already exposed via bpf_prog_info.

    hum, I can't see that (on bpf-next/master)
    would the attached change be ok with you?

    jirka


    ---
    diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h
    index e6679393b687..2ce9c9d41c2b 100644
    --- a/include/uapi/linux/bpf.h
    +++ b/include/uapi/linux/bpf.h
    @@ -1062,6 +1062,7 @@ struct bpf_prog_info {
    __u32 ifindex;
    __u64 netns_dev;
    __u64 netns_ino;
    + __u16 gpl_compatible:1;
    } __attribute__((aligned(8)));

    struct bpf_map_info {
    diff --git a/kernel/bpf/syscall.c b/kernel/bpf/syscall.c
    index fe23dc5a3ec4..7bb4ff1c770a 100644
    --- a/kernel/bpf/syscall.c
    +++ b/kernel/bpf/syscall.c
    @@ -1914,6 +1914,7 @@ static int bpf_prog_get_info_by_fd(struct bpf_prog *prog,
    info.load_time = prog->aux->load_time;
    info.created_by_uid = from_kuid_munged(current_user_ns(),
    prog->aux->user->uid);
    + info.gpl_compatible = prog->gpl_compatible;

    memcpy(info.tag, prog->tag, sizeof(prog->tag));
    memcpy(info.name, prog->aux->name, sizeof(prog->aux->name));
    \
     
     \ /
      Last update: 2018-04-25 12:17    [W:4.789 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site