Messages in this thread | | | Date | Tue, 24 Apr 2018 19:25:13 +0200 | From | Ahmed Abdelsalam <> | Subject | Re: [net-next 1/2] ipv6: sr: add a per namespace sysctl to control seg6 flowlabel |
| |
On Tue, 24 Apr 2018 13:16:50 -0400 (EDT) David Miller <davem@davemloft.net> wrote:
> From: Ahmed Abdelsalam <amsalam20@gmail.com> > Date: Mon, 23 Apr 2018 23:36:59 +0200 > > > This patch adds a per namespace sysctl, named 'seg6_flowlabel', to be used > > by seg6_do_srh_encap() to control the behaviour of setting the flowlabel > > value of outer IPv6. > > > > The currently support behaviours are as follows: > > -1 set flowlabel to zero. > > 0 copy flowlabel from Inner paceket in case of Inner IPv6 (0 for IPv4/L2) > > 1 Compute the flowlabel using seg6_make_flowlabel() > > > > Signed-off-by: Ahmed Abdelsalam <amsalam20@gmail.com> > > There really isn't a reason to make this a separate patch. > > Adding a sysctl that nothing refers to doesn't add much value. > > So please combine patches #1 and #2.
Ok, I will combine them and send you a new patch.
Thanks
-- Ahmed Abdelsalam <amsalam20@gmail.com>
| |