lkml.org 
[lkml]   [2018]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] Makefile: Fix typo s/HOST_LOADLIBES/HOST_LOADLIBS
2018-04-24 17:44 GMT+09:00 Sedat Dilek <sedat.dilek@credativ.de>:
> Signed-off-by: Sedat Dilek <sedat.dilek@credativ.de>
> ---
> Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 83b6c541565a..e1869dc08288 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -366,7 +366,7 @@ HOSTCFLAGS := -Wall -Wmissing-prototypes -Wstrict-prototypes -O2 \
> -fomit-frame-pointer -std=gnu89 $(HOST_LFS_CFLAGS)
> HOSTCXXFLAGS := -O2 $(HOST_LFS_CFLAGS)
> HOSTLDFLAGS := $(HOST_LFS_LDFLAGS)
> -HOST_LOADLIBES := $(HOST_LFS_LIBS)
> +HOST_LOADLIBS := $(HOST_LFS_LIBS)
>
> # Make variables (CC, etc...)
> AS = $(CROSS_COMPILE)as
> @@ -433,7 +433,7 @@ LDFLAGS :=
> GCC_PLUGINS_CFLAGS :=
>
> export ARCH SRCARCH CONFIG_SHELL HOSTCC HOSTCFLAGS CROSS_COMPILE AS LD CC
> -export CPP AR NM STRIP OBJCOPY OBJDUMP HOSTLDFLAGS HOST_LOADLIBES
> +export CPP AR NM STRIP OBJCOPY OBJDUMP HOSTLDFLAGS HOST_LOADLIBS
> export MAKE LEX YACC AWK GENKSYMS INSTALLKERNEL PERL PYTHON PYTHON2 PYTHON3 UTS_MACHINE
> export HOSTCXX HOSTCXXFLAGS LDFLAGS_MODULE CHECK CHECKFLAGS
>

Why is this a typo?


Our Makefiles use HOST_LOADLIBES consistently.


$ git grep HOST_LOADLIB
Makefile:HOST_LOADLIBES := $(HOST_LFS_LIBS)
Makefile:export CPP AR NM STRIP OBJCOPY OBJDUMP HOSTLDFLAGS HOST_LOADLIBES
scripts/Makefile.host: $(HOST_LOADLIBES) $(HOSTLOADLIBES_$(@F))
scripts/Makefile.host: $(HOST_LOADLIBES)
$(HOSTLOADLIBES_$(@F))
scripts/Makefile.host: $(HOST_LOADLIBES)
$(HOSTLOADLIBES_$(@F))
scripts/Makefile.host: $(HOST_LOADLIBES)
$(HOSTLOADLIBES_$(@F))
scripts/Makefile.host: $(HOST_LOADLIBES)
$(HOSTLOADLIBES_$(@F))




--
Best Regards
Masahiro Yamada

\
 
 \ /
  Last update: 2018-04-24 17:52    [W:0.056 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site