Messages in this thread | | | From | Bartlomiej Zolnierkiewicz <> | Subject | Re: [PATCH] video: fbdev: aty: radeon_pm: Replace mdelay with msleep in radeonfb_pci_suspend | Date | Tue, 24 Apr 2018 17:51:23 +0200 |
| |
On Tuesday, April 10, 2018 09:47:20 AM Jia-Ju Bai wrote: > radeonfb_pci_suspend() is never called in atomic context. > > radeonfb_pci_suspend() is only set as ".suspend" in struct pci_driver. > This function is not called in atomic context. > > Despite never getting called from atomic context, radeonfb_pci_suspend() > calls mdelay() to busily wait. > This is not necessary and can be replaced with msleep() > and usleep_range() to avoid busy waiting. > > This is found by a static analysis tool named DCNS written by myself. > And I also manually check it. > > Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Patch queued for 4.18, thanks.
Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics
| |