Messages in this thread | | | Date | Tue, 24 Apr 2018 16:29:02 +0200 | From | Christoph Hellwig <> | Subject | Re: [PATCH 03/39] proc: introduce proc_create_seq_private |
| |
On Thu, Apr 19, 2018 at 09:50:27PM +0300, Alexey Dobriyan wrote: > On Thu, Apr 19, 2018 at 02:41:04PM +0200, Christoph Hellwig wrote: > > Variant of proc_create_data that directly take a struct seq_operations > > > --- a/fs/proc/internal.h > > +++ b/fs/proc/internal.h > > @@ -45,6 +45,7 @@ struct proc_dir_entry { > > const struct inode_operations *proc_iops; > > const struct file_operations *proc_fops; > > const struct seq_operations *seq_ops; > > + size_t state_size; > > "unsigned int" please. > > Where have you seen 4GB priv states?
We're passing the result of sizeof, which happens to be a size_t. But if it makes you happy I can switch to unsigned int.
| |