Messages in this thread | | | From | Chris Wilson <> | Subject | Re: [PATCH] drm/i915/selftests: Fix uninitialized variable | Date | Tue, 24 Apr 2018 14:36:53 +0100 |
| |
Quoting Gustavo A. R. Silva (2018-04-24 14:30:58) > > > On 04/24/2018 08:22 AM, Chris Wilson wrote: > > Quoting Gustavo A. R. Silva (2018-04-24 14:15:45) > >> There is a potential execution path in which variable err is > >> returned without being properly initialized previously. > >> > >> Fix this by initializing variable err to 0. > > > > err is only returned along an error path, returning 0 would not be > > useful. Which path? All the error paths look correct to me. > > -Chris > > > > If the following two conditions take the false branch then the function > returns err with a random stack value:
It would help if I read the right function. Ok, Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> -Chris
| |