Messages in this thread | | | Subject | Re: [PATCH 0/8] Fix year 2038 issue for sound subsystem | From | Jaroslav Kysela <> | Date | Tue, 24 Apr 2018 15:29:24 +0200 |
| |
Dne 24.4.2018 v 14:06 Baolin Wang napsal(a): > Since many structures will use timespec type variables to record time stamp > in uapi/asound.h, which are not year 2038 safe on 32bit system. This patchset > tries to introduce new structures removing timespec type to compatible native > mode and compat mode. > > Moreover this patchset also converts the internal structrures to use timespec64 > type and related APIs.
Thanks for your patchset. A few comments:
It might be more nice to reuse the existing structures and put timespec64 to the reserved field and duplicate information (with the 32-bit wrapping for the old fields). It means that we do not need new ioctls and old libraries will be fine.
It may make sense to define private snd_timespec32 and snd_timespec64 with s32/s64 types instead separate sec/usec fields.
Jaroslav
-- Jaroslav Kysela <perex@perex.cz> Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
| |