Messages in this thread | | | Date | Tue, 24 Apr 2018 14:35:23 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH] sched/fair: Rearrange select_task_rq_fair() to optimize it |
| |
On Tue, Apr 24, 2018 at 12:19:07PM +0100, Valentin Schneider wrote: > On 24/04/18 11:43, Peter Zijlstra wrote: > > On Tue, Apr 24, 2018 at 11:02:26AM +0100, Valentin Schneider wrote: > >> I'd argue making things easier to read is a non-negligible part as well. > > > > Right, so I don't object to either of these (I think); but it would be > > good to see this in combination with that proposed EAS change. > > > > True, I would've said the call to find_energy_efficient_cpu() ([1]) could > simply be added to the if (sd) {} case, but...
I think the proposal was to put it before the for_each_domain() loop entirely, however...
> > I think you (valentin) wanted to side-step the entire domain loop in > > that case or something. > > > > ...this would change more things. Admittedly I've been sort of out of the loop > (no pun intended) lately, but this doesn't ring a bell. That might have been > the other frenchie (Quentin) :)
It does indeed appear I confused the two of you, it was Quentin playing with that.
In any case, if there not going to be conflicts here, this all looks good.
| |