lkml.org 
[lkml]   [2018]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5] fs: dax: Adding new return type vm_fault_t
On Tue, Apr 24, 2018 at 11:29:39AM +0530, Souptick Joarder wrote:
> On Tue, Apr 24, 2018 at 1:19 AM, Matthew Wilcox <willy@infradead.org> wrote:
> > On Mon, Apr 23, 2018 at 11:36:25PM +0530, Souptick Joarder wrote:
> >> If the insertion of PTE failed because someone else
> >> already added a different entry in the mean time, we
> >> treat that as success as we assume the same entry was
> >> actually inserted.
> >
> > No, Jan said to *make it a comment*. In the source file. That's why
> > he formatted it with the /* */. Not in the changelog.
> Sorry, got confused.
>
> I think this should be fine -
>
> +/*
> +If the insertion of PTE failed because someone else
> +already added a different entry in the mean time, we
> +treat that as success as we assume the same entry was
> +actually inserted.
> +*/

Jan literally typed out exactly what you need to insert:

/*
* If the insertion of PTE failed because someone else already added a
* different entry in the mean time, we treat that as success as we assume
* the same entry was actually inserted.
*/

For some reason you've chosen to wrap the lines shorter than Jan had them,
and use a different comment formatting style from the rest of the kernel.
Why? I'd suggest re-reading Documentation/process/coding-style.rst

\
 
 \ /
  Last update: 2018-04-24 13:45    [W:0.039 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site