lkml.org 
[lkml]   [2018]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] usb: always build usb/common/ targets; fixes extcon-axp288 build error
From
Date
Hi,

On 24-04-18 09:42, Chanwoo Choi wrote:
> On 2018년 04월 17일 18:01, Hans de Goede wrote:
>> Hi,
>>
>> On 17-04-18 07:14, Randy Dunlap wrote:
>>> From: Randy Dunlap <rdunlap@infradead.org>
>>>
>>> The extcon-axp288 driver selects USB_ROLE_SWITCH, but the USB
>>> Makefile does not currently build drivers/usb/common/ (where
>>> USB_ROLE_SWITCH code is) unless USB_COMMON is set, so modify
>>> the USB Makefile to always descend into drivers/usb/common/
>>> to build its configured targets.
>>>
>>> Fixes these build errors:
>>>
>>> ERROR: "usb_role_switch_get" [drivers/extcon/extcon-axp288.ko] undefined!
>>> ERROR: "usb_role_switch_set_role" [drivers/extcon/extcon-axp288.ko] undefined!
>>> ERROR: "usb_role_switch_get_role" [drivers/extcon/extcon-axp288.ko] undefined!
>>> ERROR: "usb_role_switch_put" [drivers/extcon/extcon-axp288.ko] undefined!
>>>
>>> An alternative patch would be to select USB_COMMON in the EXTCON_AXP288
>>> driver Kconfig entry, but this would build more code in
>>> drivers/usb/common/ than is necessary.
>>
>> Ah, that variant of fixing this got posted yesterday and I acked that,
>> but I agree that this version is better.
>>
>> Greg, what is your take on this fix?
>>
>> Chanwoo Choi, please wait with merging the fix from yesterday until
>> we've a decision which fix to use.
>
> OK. I'll not send pull request for fix patches until deciding them.

Greg has picked up another patch to fix this, so you can drop this.

Regards,

Hans

\
 
 \ /
  Last update: 2018-04-24 10:49    [W:0.423 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site