lkml.org 
[lkml]   [2018]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] random: fix possible sleeping allocation from irq context
From
Date
Theodore Ts\'o wrote:
> We can do a sleeping allocation from an irq context when CONFIG_NUMA
> is enabled. Fix this by initializing the NUMA crng instances in a
> workqueue.

Offloading to workqueue context itself would be OK,
but this patch makes linux.git unbootable because

if (crng == &primary_crng && crng_init < 2) {
invalidate_batched_entropy();
numa_crng_init(); // <= Deferred to workqueue context.
crng_init = 2; // <= Not waiting for workqueue context, and oops before console becomes ready. ;-)
process_random_ready_list();
wake_up_interruptible(&crng_init_wait);
pr_notice(\"random: crng init done\\n\");
}

Please don\'t pretend rng_ready() before workqueue context is processed.

\
 
 \ /
  Last update: 2018-04-25 02:47    [W:0.098 / U:0.388 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site