lkml.org 
[lkml]   [2018]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] do not call trace_printk on non-debug build
On Tue, 24 Apr 2018 16:45:05 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Tue, 24 Apr 2018 20:39:27 +0000
> Wei Wang <wvw@google.com> wrote:
>
> > The config is not something new and it is controlling pr_debug and
> > pr_devel, so might not be too annoying, IMHO. But I agree this is not a
> > problem from us but from abusers.
>
> And is the reason I never use pr_debug() and pr_devel().
>

Which reminds me, I need to replace pr_debug() to pr_info() for this
line:

pr_debug("syscall %s metadata not mapped, disabling ftrace event\n",

In trace_syscalls.c (I didn't add that), as a different commit that
changed syscall names for x86 caused all syscall tracepoints to
disappear. And if this was pr_info() and not pr_debug() the one that
made the change would have noticed his change had impact someplace else.

-- Steve

\
 
 \ /
  Last update: 2018-04-24 22:49    [W:0.107 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site