Messages in this thread | | | Date | Mon, 23 Apr 2018 18:44:19 +0200 (CEST) | From | Sebastian Ott <> | Subject | Re: [BUG, PATCH] random: sleep in irq context |
| |
On Mon, 23 Apr 2018, Sebastian Ott wrote: > From 9d29e0c92efaf94277bc178782523283958ae8c8 Mon Sep 17 00:00:00 2001 > From: Sebastian Ott <sebott@linux.ibm.com> > Date: Mon, 23 Apr 2018 14:59:20 +0200 > Subject: [PATCH] random: don't sleep during allocations in irq context > > Since numa_crng_init() can be called from irq context let's > use __GFP_ATOMIC for allocations. > > Fixes: 8ef35c866f88 ("random: set up the NUMA crng instances...") > Signed-off-by: Sebastian Ott <sebott@linux.ibm.com> > --- > drivers/char/random.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/char/random.c b/drivers/char/random.c > index 3cd3aae24d6d..e96ea2bf7241 100644 > --- a/drivers/char/random.c > +++ b/drivers/char/random.c > @@ -791,14 +791,14 @@ static void crng_initialize(struct crng_state *crng) > #ifdef CONFIG_NUMA > static void numa_crng_init(void) > { > + gfp_t gfp_flags = GFP_KERNEL | __GFP_NOFAIL | __GFP_ATOMIC;
I should have removed GFP_KERNEL here...
| |