Messages in this thread | | | From | Rui Miguel Silva <> | Subject | Re: [PATCH v5 1/2] media: ov2680: dt: Add bindings for OV2680 | Date | Mon, 23 Apr 2018 16:09:55 +0100 |
| |
Hi Fabio, Thanks for the review.
On Mon 23 Apr 2018 at 14:11, Fabio Estevam wrote: > Hi Rui, > > On Thu, Apr 19, 2018 at 8:00 AM, Rui Miguel Silva > <rui.silva@linaro.org> wrote: > >> +Optional Properties: >> +- powerdown-gpios: reference to the GPIO connected to the >> powerdown pin, >> + if any. This is an active high signal to >> the OV2680. > > I looked at the OV2680 datasheet and I see a pin called XSHUTDN, > which has > the following description: > > XSHUTDN: reset and power down (active low with internal pull > down resistor) > > So it should be active low, not active high.
Yes, you are correct, I will fix this, and the dts entry.
Thanks.
--- Cheers, Rui
| |